Merge pull request #11 from tintoy/fix/issue10

Fix incorrect behaviour when configuring Seq

.editorconfig

@@ -16,6 +16,9 @@ indent_size = 2
 insert_final_newline = true
 charset = utf-8
 
+[*.rst]
+trim_trailing_whitespace = false
+
 [*.bat]
 indent_style = tab
 end_of_line = crlf

HISTORY.rst

@@ -2,6 +2,12 @@
 History
 =======
 
+0.3.10 (2018-08-11)
+-------------------
+
+* Fix incorrect behaviour when configuring logging from a file (tintoy/seqlog#10).  
+  **Breaking change**: Configuring logging from file or dict will now by default override the default logger class to be ``StructuredLogger`` (this can be reverted to previous behaviour by passing ``use_structured_logger=False``).
+
 0.3.9 (2018-01-09)
 ------------------
 

meta.yaml

@@ -1,6 +1,6 @@
 package:
   name: seqlog
-  version: 0.3.9
+  version: 0.3.10
 
 requirements:
   host:

seqlog/__init__.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 
 import logging
+import logging.config
 import yaml
 
 from seqlog.structured_logging import StructuredLogger, StructuredRootLogger
@@ -12,10 +13,10 @@
 
 __author__ = 'Adam Friedman'
 __email__ = 'tintoy@tintoy.io'
-__version__ = '0.3.9'
+__version__ = '0.3.10'
 
 
-def configure_from_file(file_name, override_root_logger=True):
+def configure_from_file(file_name, override_root_logger=True, use_structured_logger=True):
     """
     Configure Seq logging using YAML-format configuration file.
 
@@ -24,6 +25,7 @@ def configure_from_file(file_name, override_root_logger=True):
     :param file_name: The name of the configuration file to use.
     :type file_name: str
     :param override_root_logger: Override the root logger to use a Seq-specific implementation? (default: True)
+    :param use_structured_logger: Configure the default logger class to be StructuredLogger, which support named format arguments? (default: True)
     :type override_root_logger: bool
     """
 
@@ -33,7 +35,7 @@ def configure_from_file(file_name, override_root_logger=True):
     configure_from_dict(config, override_root_logger)
 
 
-def configure_from_dict(config, override_root_logger=True):
+def configure_from_dict(config, override_root_logger=True, use_structured_logger=True):
     """
     Configure Seq logging using a dictionary.
 
@@ -42,12 +44,17 @@ def configure_from_dict(config, override_root_logger=True):
     :param config: A dict containing the configuration.
     :type config: dict
     :param override_root_logger: Override the root logger to use a Seq-specific implementation? (default: True)
+    :param use_structured_logger: Configure the default logger class to be StructuredLogger, which support named format arguments? (default: True)
     :type override_root_logger: bool
     """
 
     if override_root_logger:
         _override_root_logger()
 
+    # Must use StructuredLogger to support named format argments.
+    if (use_structured_logger):
+        logging.setLoggerClass(StructuredLogger)
+
     logging.config.dictConfig(config)
 
 

setup.py

@@ -32,7 +32,7 @@
 
 setup(
     name='seqlog',
-    version='0.3.9',
+    version='0.3.10',
     description="SeqLog enables logging from Python to Seq.",
     long_description=readme + '\n\n' + history,
     author="Adam Friedman",