Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update adds extra " characters around string objects logged #48

Closed
tomzorz opened this issue Apr 17, 2023 · 7 comments
Closed

Latest update adds extra " characters around string objects logged #48

tomzorz opened this issue Apr 17, 2023 · 7 comments
Assignees

Comments

@tomzorz
Copy link

tomzorz commented Apr 17, 2023

  • PySeq version: latest (0.3.24)
  • Python version: 3.9
  • Operating System: AWS Linux

Description

The latest update seems to have added extra " characters around string objects.

image

vs. before (tested 0.3.20):

image

This of course breaks signals and json parsing and more...

What I Did

I noticed the change because we haven't touched anything logging related, but also haven't fixed the version in our requirements.txt - so the new deploys just pulled in the latest version.

@tintoy
Copy link
Owner

tintoy commented Apr 18, 2023

Yeah sorry about that - seems like it may be related to changes for #42

@tintoy tintoy self-assigned this Apr 18, 2023
@tintoy
Copy link
Owner

tintoy commented Apr 18, 2023

Can you give v0.3.25 a try, and see if that works for you?

@tomzorz
Copy link
Author

tomzorz commented Apr 19, 2023

I just had a chance to try, it still seems to be broken

@tintoy
Copy link
Owner

tintoy commented Apr 19, 2023

Hmm, ok - looks like we’ll need to roll the entire feature back for now. Thanks.

@tintoy
Copy link
Owner

tintoy commented Apr 19, 2023

Published v0.3.26.

It seems to work as far as I've been able to test it, but I don't have access to my old Seq instance so have had to rely on somewhat more theoretical testing than usual 🙂

@Vacant0mens
Copy link
Collaborator

Yeah sorry about that - seems like it may be related to changes for #42

It's looking much better now on the master branch. Sorry for the hastiness in my stack_info issue. 😬

@tintoy
Copy link
Owner

tintoy commented Jul 26, 2023

All good - thanks for the improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants