Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint on set_global_log_properties #60

Closed
robin523790 opened this issue Aug 23, 2023 · 3 comments
Closed

Type hint on set_global_log_properties #60

robin523790 opened this issue Aug 23, 2023 · 3 comments

Comments

@robin523790
Copy link

  • PySeq version: 0.3.28
  • Python version: 3.11.3
  • Operating System: Windows

Description

NOTE: This is only a display error in PyCharm. Execution of the code works fine, and neither VSCode nor pylance nor pyright report any issues.

PyCharm reports a type error on set_global_log_properties():

image

This is because the type is defined as dict[str, dict] instead of dict[str, str] in the comment:

image

Suggested solution

According to https://peps.python.org/pep-0484/#arbitrary-argument-lists-and-default-argument-values it should be OK to change the type to str... and in fact, the error goes away.

@tintoy
Copy link
Owner

tintoy commented Aug 23, 2023

Thanks for reporting! I'll get this done tomorrow morning 🙂

tintoy added a commit that referenced this issue Aug 24, 2023
@tintoy
Copy link
Owner

tintoy commented Aug 24, 2023

Published v0.3.29 🙂

@Vacant0mens
Copy link
Collaborator

merged and published. closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants