Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always shows line 219 in log in python 3.11 #69

Open
Liquidmasl opened this issue Apr 9, 2024 · 5 comments
Open

always shows line 219 in log in python 3.11 #69

Liquidmasl opened this issue Apr 9, 2024 · 5 comments
Labels

Comments

@Liquidmasl
Copy link

  • PySeq version: 0.3.30
  • Python version: 3.11
  • Operating System: win11 (and linux in containers)

Description

all log entries show line 219

What I Did

i traced it back to the basic logging implementation. find_caller() returnes _log() in strucutred loggong.py, line 219

in this line
super()._log(level, msg, args, exc_info, extra, stack_info)
is called

changing that to
super()._log(level, msg, args, exc_info, extra, stack_info, stacklevel=2)
fixes the issue!

maybe i find the time making a pr, should be quick and easy.
but i have one single container, that does not have that issue. exactly the one i cannot debug. So i am not sure whatup there

@Liquidmasl
Copy link
Author

the one container where it works fine is running on python 3.10, rest on 3.11
i guess theres the issue

@Liquidmasl Liquidmasl changed the title always shows line 219 in log always shows line 219 in log in python 3.11 Apr 9, 2024
@tintoy
Copy link
Owner

tintoy commented Apr 9, 2024

Thanks, good find!

@tintoy tintoy added the bug label Apr 9, 2024
@tintoy
Copy link
Owner

tintoy commented Apr 9, 2024

(feel free to open a PR if you have time, otherwise I'll do it later this week 🙂)

tintoy added a commit that referenced this issue Apr 12, 2024
@tintoy
Copy link
Owner

tintoy commented Apr 27, 2024

Ok; sorry for the delay, I've been away on vacation 🙂

Published v0.3.31!

@tintoy
Copy link
Owner

tintoy commented Apr 27, 2024

When you get a chance, could you try it out and let me know if it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants