You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 30, 2019. It is now read-only.
The Metatags service exposes the $window service on its object. When the implementing app puts the Metatags service on the $rootScope the whole window object is in turn exposed on the $rootScope.
This feels like a big scope pollution, and might have performance impact.
as far as I can see there are 2 solutions
Use a Weakmap outside the class to store $window as a 'private' member.
Do not use window at all (I think it is only used for retreiving the absolute page URL, but the $state service can do that to.
The text was updated successfully, but these errors were encountered:
oh a 3rd way, do not expose the derrived metatags directly on the Metatag service but rather in an obeject that you put on the service, and we put that on the rootScope
The Metatags service exposes the $window service on its object. When the implementing app puts the Metatags service on the $rootScope the whole window object is in turn exposed on the $rootScope.
This feels like a big scope pollution, and might have performance impact.
as far as I can see there are 2 solutions
The text was updated successfully, but these errors were encountered: