Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed (some) trivial unused variable warnings #1008

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edeforas
Copy link
Contributor

@edeforas edeforas commented Jan 1, 2019

works not finished, but these ones are trivial

Copy link
Contributor

@beru beru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhack bhack self-requested a review January 2, 2019 09:53
@beru
Copy link
Contributor

beru commented Jan 5, 2019

I cannot merge this PR because passing Travis CI build is required.

@nyanp @edgarriba Can I remove osx build jobs from .travis.yml file?
It's broken and no longer maintained.

@edgarriba
Copy link
Member

@beru sure, go ahead. Open an issue to address this error so others can fix it in the future.

@beru
Copy link
Contributor

beru commented Jan 8, 2019

@beru sure, go ahead. Open an issue to address this error so others can fix it in the future.

@edgarriba I've just opened the issue. #1009

@hzxie
Copy link
Contributor

hzxie commented Feb 20, 2019

The main problem cause the build error on macOS is that pip is not installed.

Solution 1

Remove pip install --user cpplint

Because cpplint is no longer used in CI.

Solution 2

I'm not sure whether the solution works or not.

According to the issue in Travis CI, you can change it to:

pip3 install --user cpplint

Solution 3

Install pip with the following command:

curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py
python get-pip.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants