An option to be indepedent of OpenCV #167

beru · 2016-06-05T03:20:31Z

It's hard to deny that OpenCV is a de-facto standard library in computer vision.
But it's rather huge for my PC-9801 computer.

nyanp · 2016-06-05T15:33:41Z

@beru
Excellent! Attempts to reduce dependencies are always welcome in tiny-cnn :)
Could you extract stb version of test program as the independent file? I want to keep example source code as clean as possible, for both OpenCV&stb users.

relocate stb_image files

beru · 2016-06-05T17:19:25Z

@nyanp
I updated the branch. Would you check it please?

nyanp · 2016-06-05T22:48:57Z

CMakeLists.txt

@@ -54,7 +56,7 @@ OPTION(BUILD_DOCS "Set to ON to build documentation" OFF)
 #   Find Dependencies
 # ----------------------------------------------------------------------------

-IF(BUILD_EXAMPLES)
+IF(USE_OPENCV)


@beru
In this PR CMake requires opencv even if we don't compile the mnist example (This is why AppVeyor failed to build). We need opencv only when BUILD_EXAMPLS && USE_OPENCV. Could you fix it?

…omment) indentation adjustments

beru · 2016-06-05T23:41:28Z

Thank you for pointing out the problem. I updated CMakeLists.txt file.
Could you please take a look at it again?

nyanp · 2016-06-06T03:43:47Z

@beru
Perfect :) I'll merge it. Thank you very much!

edgarriba · 2016-06-06T08:55:51Z

@beru nice contribution!
Could you implement a find_package cmake instead of adding the header files?

Take a look how I solved this for NNPACK: https://github.com/edgarriba/tiny-cnn/tree/feat/generic-computational-graph-device-abstraction/cmake/Modules

Extra link: Writing find modules https://cmake.org/Wiki/CMake:How_To_Find_Libraries

edgarriba · 2016-06-08T05:51:44Z

@nyanp This need some fixes for new branch.

relocate stb_image files

…omment) indentation adjustments

relocate stb_image files

* v0.0.1 -> v.0.1.0 - Now we can handle non-sequential model as ```network<graph>``` #108 #153 - Catch up the latest format of caffe's proto #162 - Improve the default behaviour of re-init weight #136 - Add more tests and documents #73 - Remove dependency of OpenCV in MNIST example * Create DeviceAbstraction.puml Create test.md Update test.md Update and rename test.md to device-abstraction-uml.md Create device-abstraction-uml.puml Update readme.md reorganize cmake reorganize cmake remove test warnings remove mock files Update device-abstraction-uml.puml * add tests&comments * cleanup codes currently we don't need hand-written ctor/dtors in dropout * Remove OpenCV dependency closes #2 * fix comments * update build instruction file * support CNN_USE_OPENCV build config * fix build configuration file * change the location of stb_image header files * follows the comment #167 (comment) relocate stb_image files * Update layer.h * Implement on deconvolution and unpooling layer. * core module skeletons * Added test case in separate cpp file to force link errors if there are duplicate symbols when including tiny_cnn.h in multiple .cpp files. * Fix linker error due to duplicate symbols. * Update README.md - Update layer catalogue - Upgrade example codes to v0.1.0 * update first convolutional layer abstraction version with NNPACK support base methods for new API update find_package NNPACK update tiny_backend fix segfault by adding move constructor to conv layer refactor nnp_backend update UML with new design fix required libs in cmake, set float_t as float and set activation vector as input in nnpack fix padding and add assertion after nnp_convolution_inference fix CMake warnings and reorganize modules fix data race fix broken tests Reorganize CMake modules add epsilon for broken tests fix broken tests. float_t was missing in some layers. fix clang errors

beru · 2016-06-17T05:33:02Z

@edgarriba
Thank you for the kind messages.
I've noticed the problem but I'm slow to react. Sorry for the delay.
I posted another PR #189 recently. I wish that can fix the problem.

Talking about using CMake find_package command feature for stb_image.
Since stb_image is a single-file headers library and it doesn't have a Makefile so I'm not sure if it is designed to be installed into certain path. Probablly stb_image library is not registered to repositories of famous package managers too. So I'd rather the files to be accompanied with tiny-cnn.

relocate stb_image files

* Remove OpenCV dependency closes #2 * update build instruction file * change the location of stb_image header files * follows the comment #167 (comment) relocate stb_image files * Implement on deconvolution and unpooling layer. * Create DeviceAbstraction.puml Create test.md Update test.md Update and rename test.md to device-abstraction-uml.md Create device-abstraction-uml.puml Update readme.md reorganize cmake reorganize cmake remove test warnings remove mock files Update device-abstraction-uml.puml * switch std::bind to lambdas * first commit to split into small backends split tiny convolutional kernels split NNPACK kernel and reorganize backend files split maxpool kernels simplify conv2d_back signature split fully connected layer kernels reorganize folders check NNPACK prerequisites add coloured nn_error, nn_warning and nn_info uncomment tiny backend

relocate stb_image files

…omment) indentation adjustments

An option to be indepedent of OpenCV

* v0.0.1 -> v.0.1.0 - Now we can handle non-sequential model as ```network<graph>``` tiny-dnn#108 tiny-dnn#153 - Catch up the latest format of caffe's proto tiny-dnn#162 - Improve the default behaviour of re-init weight tiny-dnn#136 - Add more tests and documents tiny-dnn#73 - Remove dependency of OpenCV in MNIST example * Create DeviceAbstraction.puml Create test.md Update test.md Update and rename test.md to device-abstraction-uml.md Create device-abstraction-uml.puml Update readme.md reorganize cmake reorganize cmake remove test warnings remove mock files Update device-abstraction-uml.puml * add tests&comments * cleanup codes currently we don't need hand-written ctor/dtors in dropout * Remove OpenCV dependency closes #2 * fix comments * update build instruction file * support CNN_USE_OPENCV build config * fix build configuration file * change the location of stb_image header files * follows the comment tiny-dnn#167 (comment) relocate stb_image files * Update layer.h * Implement on deconvolution and unpooling layer. * core module skeletons * Added test case in separate cpp file to force link errors if there are duplicate symbols when including tiny_cnn.h in multiple .cpp files. * Fix linker error due to duplicate symbols. * Update README.md - Update layer catalogue - Upgrade example codes to v0.1.0 * update first convolutional layer abstraction version with NNPACK support base methods for new API update find_package NNPACK update tiny_backend fix segfault by adding move constructor to conv layer refactor nnp_backend update UML with new design fix required libs in cmake, set float_t as float and set activation vector as input in nnpack fix padding and add assertion after nnp_convolution_inference fix CMake warnings and reorganize modules fix data race fix broken tests Reorganize CMake modules add epsilon for broken tests fix broken tests. float_t was missing in some layers. fix clang errors

* Remove OpenCV dependency closes #2 * update build instruction file * change the location of stb_image header files * follows the comment tiny-dnn#167 (comment) relocate stb_image files * Implement on deconvolution and unpooling layer. * Create DeviceAbstraction.puml Create test.md Update test.md Update and rename test.md to device-abstraction-uml.md Create device-abstraction-uml.puml Update readme.md reorganize cmake reorganize cmake remove test warnings remove mock files Update device-abstraction-uml.puml * switch std::bind to lambdas * first commit to split into small backends split tiny convolutional kernels split NNPACK kernel and reorganize backend files split maxpool kernels simplify conv2d_back signature split fully connected layer kernels reorganize folders check NNPACK prerequisites add coloured nn_error, nn_warning and nn_info uncomment tiny backend

beru added 8 commits June 4, 2016 23:21

Remove OpenCV dependency closes #2

0372f76

fix comments

19fd4de

update build instruction file

54a74a4

support CNN_USE_OPENCV build config

5ec2711

fix build configuration file

b60c25b

change the location of stb_image header files

e26c8b2

change default value of USE_OPENCV option

ce12366

fix build config file

e4f6ea5

follows the comment tiny-dnn#167 (comment)

e792044

relocate stb_image files

nyanp reviewed Jun 5, 2016
View reviewed changes

fixes AppVeyor build problem by following the comment tiny-dnn#167 (c…

8227365

…omment) indentation adjustments

nyanp merged commit ce16653 into tiny-dnn:master Jun 6, 2016

edgarriba pushed a commit to edgarriba/tiny-cnn that referenced this pull request Jun 13, 2016

follows the comment tiny-dnn#167 (comment)

70cb7cd

relocate stb_image files

edgarriba pushed a commit to edgarriba/tiny-cnn that referenced this pull request Jun 13, 2016

fixes AppVeyor build problem by following the comment tiny-dnn#167 (c…

9581208

…omment) indentation adjustments

edgarriba pushed a commit to edgarriba/tiny-cnn that referenced this pull request Jun 13, 2016

follows the comment tiny-dnn#167 (comment)

56952b9

relocate stb_image files

edgarriba pushed a commit to edgarriba/tiny-cnn that referenced this pull request Jun 13, 2016

follows the comment tiny-dnn#167 (comment)

5d35cad

relocate stb_image files

beru mentioned this pull request Jun 17, 2016

fix test_with_stb_image.cpp and typos (tiny_cnn_hrds => tiny_cnn_hdrs… #189

Merged

edgarriba pushed a commit to edgarriba/tiny-cnn that referenced this pull request Jun 17, 2016

follows the comment tiny-dnn#167 (comment)

5f90374

relocate stb_image files

edgarriba pushed a commit to edgarriba/tiny-cnn that referenced this pull request Aug 8, 2016

follows the comment tiny-dnn#167 (comment)

8a64257

relocate stb_image files

edgarriba pushed a commit to edgarriba/tiny-cnn that referenced this pull request Aug 8, 2016

fixes AppVeyor build problem by following the comment tiny-dnn#167 (c…

b888d42

…omment) indentation adjustments

edgarriba pushed a commit to edgarriba/tiny-cnn that referenced this pull request Aug 8, 2016

Merge pull request tiny-dnn#167 from beru/without_opencv

7a4f484

An option to be indepedent of OpenCV

beru deleted the without_opencv branch January 8, 2017 02:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

An option to be indepedent of OpenCV #167

An option to be indepedent of OpenCV #167

beru commented Jun 5, 2016

nyanp commented Jun 5, 2016

beru commented Jun 5, 2016

nyanp Jun 5, 2016

beru commented Jun 5, 2016

nyanp commented Jun 6, 2016

edgarriba commented Jun 6, 2016

edgarriba commented Jun 8, 2016

beru commented Jun 17, 2016

An option to be indepedent of OpenCV #167

An option to be indepedent of OpenCV #167

Conversation

beru commented Jun 5, 2016

nyanp commented Jun 5, 2016

beru commented Jun 5, 2016

nyanp Jun 5, 2016

Choose a reason for hiding this comment

beru commented Jun 5, 2016

nyanp commented Jun 6, 2016

edgarriba commented Jun 6, 2016

edgarriba commented Jun 8, 2016

beru commented Jun 17, 2016