Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Coverity-Scan API token in Travis #626

Merged
merged 7 commits into from Apr 6, 2017
Merged

Enable Coverity-Scan API token in Travis #626

merged 7 commits into from Apr 6, 2017

Conversation

nyanp
Copy link
Member

@nyanp nyanp commented Mar 20, 2017

This is continued from #531. This PR replaces dummy API token with encrypted token for coverity scan-build.

@mention-bot
Copy link

@nyanp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edgarriba, @Abai and @Randl to be potential reviewers.

@Randl
Copy link
Contributor

Randl commented Mar 20, 2017

I suppose to change notification email, and also branch. Master probably would mean checks are performed too often.

@nyanp
Copy link
Member Author

nyanp commented Mar 22, 2017

@Randl It's up to you to change your notification settings :) Any suggestions to avoid interrupting our mailbox?

@Randl
Copy link
Contributor

Randl commented Mar 23, 2017

@nyanp Well there is that site, https://www.kill-the-newsletter.com/ , which converts emails to RSS. Not sure if appropriate, but might be worth trying

@edgarriba
Copy link
Member

is there any way to show results in a badge? https://shields.io/

@Randl
Copy link
Contributor

Randl commented Mar 26, 2017

I don't think so

@edgarriba
Copy link
Member

well I see this: https://img.shields.io/coverity/scan/3997.svg
however not sure which output gives

@nyanp
Copy link
Member Author

nyanp commented Mar 31, 2017

Coverity allows us to submit 4 builds/day.
https://scan.coverity.com/faq#frequency

We might need to separate the coverity build to coverity_scan branch and invoke build by hand (as they recommend at https://scan.coverity.com/faq#frequency) in order to avoid build breaking due to the API restriction.

I met an another problem around TBB with clang (clang 3.5.0 couldn't find std::is_tribially_copyable in the latest version of TBB https://travis-ci.org/tiny-dnn/tiny-dnn/jobs/214276470), but it should be treated as an another issue. I'll investigate the problem tomorrow.

@nyanp nyanp changed the base branch from master to coverity_scan April 3, 2017 14:14
@bhack
Copy link
Contributor

bhack commented Apr 3, 2017

Keras removed coverity cause was not satisfied by the quality of the service.. probably clang static coverage is enough..

@nyanp
Copy link
Member Author

nyanp commented Apr 5, 2017

@bhack
After struggling with that, I reached to the similar mind to Keras team... Anyway I think it's ok to keep coverity_scan branch as is and we should remove coverity API from master branch.

@nyanp
Copy link
Member Author

nyanp commented Apr 6, 2017

@edgarriba

I think it's ok to keep coverity_scan branch as is and we should remove coverity API from master branch.

What do you think about removing the coverity build from master branch?

@edgarriba
Copy link
Member

go ahead

@nyanp
Copy link
Member Author

nyanp commented Apr 6, 2017

ok👌

@nyanp nyanp merged commit e57144e into coverity_scan Apr 6, 2017
@nyanp nyanp deleted the coverity branch May 8, 2017 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants