-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify docs as per new activation API. #643
Modify docs as per new activation API. #643
Conversation
This bug is not reproducible by me locally. Travis failed due to 503 error, maybe a rebuild is required to see if the problem persists or was it a Travis problem itself. |
@karandesai-96 Please close and reopen the PR. |
b61875e
to
7bae991
Compare
@beru Done, I think it was a Travis problem. The build passed now. Time to bring the new API to master 🚀 |
7bae991
to
f0e87c6
Compare
I have rechecked all the differences between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR changes code snippets in existing user docs as per the new activation API. This shall be tentatively the last PR before
feat/decouple_activations
gets properly merged into master.