Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify docs as per new activation API. #643

Merged

Conversation

kdexd
Copy link
Contributor

@kdexd kdexd commented Apr 4, 2017

This PR changes code snippets in existing user docs as per the new activation API. This shall be tentatively the last PR before feat/decouple_activations gets properly merged into master.

@mention-bot
Copy link

@karandesai-96, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nyanp, @Randl and @H4kor to be potential reviewers.

@kdexd
Copy link
Contributor Author

kdexd commented Apr 4, 2017

This bug is not reproducible by me locally. Travis failed due to 503 error, maybe a rebuild is required to see if the problem persists or was it a Travis problem itself.

@beru
Copy link
Contributor

beru commented Apr 4, 2017

@kdexd kdexd closed this Apr 5, 2017
@kdexd kdexd reopened this Apr 5, 2017
@kdexd
Copy link
Contributor Author

kdexd commented Apr 5, 2017

@beru Done, I think it was a Travis problem. The build passed now. Time to bring the new API to master 🚀

@kdexd
Copy link
Contributor Author

kdexd commented Apr 8, 2017

I have rechecked all the differences between feat/decouple_activations and master, I think that after this PR is merged, we can push the new API to master.

Copy link
Contributor

@beru beru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Randl Randl merged commit b28bb91 into tiny-dnn:feat/decouple_activations Apr 9, 2017
@kdexd kdexd deleted the modify-docs-new-api branch April 9, 2017 07:11
kdexd pushed a commit to kdexd/tiny-dnn that referenced this pull request Apr 9, 2017
beru pushed a commit that referenced this pull request Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants