Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTTPS #107

Merged
merged 15 commits into from
Nov 24, 2015
Merged

Implement HTTPS #107

merged 15 commits into from
Nov 24, 2015

Conversation

tomaka
Copy link
Member

@tomaka tomaka commented Nov 23, 2015

Close #11

It's nothing difficult. The only bit that is not implemented is the API. I'm waiting for a review of #106 to decide what to do next.

@tomaka tomaka changed the title Start implementation of HTTPS Implement HTTPS Nov 24, 2015
@tomaka
Copy link
Member Author

tomaka commented Nov 24, 2015

This should now be good to go.

There is one unresolved question: what to do if the client connects to an SSL server?
To my surprise, OpenSSL generates an error if a client tries to connect to an SSL server through regular HTTP. For the moment, the server just closes the connection.

I tried sniffing packets from real HTTPS websites to see what's going on, but it looks like the browser will automatically use SSL if you use port 443, even if you type http://example.com:443.

@tomaka
Copy link
Member Author

tomaka commented Nov 24, 2015

The unresolved question is in fact not a problem. If you try to connect to https://google.fr:80 or http://google.fr:443 with an older browser you get an error from the server for both.

@frewsxcv
Copy link
Member

FYI, travis is failing

@frewsxcv
Copy link
Member

I have some nitpicky comments, but no point in holding this up for them right now. Thanks!

@frewsxcv frewsxcv closed this Nov 24, 2015
@frewsxcv frewsxcv reopened this Nov 24, 2015
frewsxcv added a commit that referenced this pull request Nov 24, 2015
@frewsxcv frewsxcv merged commit ce10419 into tiny-http:master Nov 24, 2015
@tomaka tomaka deleted the ssl branch November 24, 2015 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants