Persist setting whether to mask paste area #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/templates/custom-elements/paste-dialog.html
jdeanwallace
approved these changes
Mar 31, 2024
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
✔️ Approved
LGTM!
👀 @jotaen4tinypilot it's your turn please take a look
# Conflicts: # app/templates/custom-elements/paste-dialog.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1739. Stacked on #1764.
This PR preserves the “Mask Input” toggle state of the paste dialog by storing it as frontend setting. That way, it persists across page refreshs.
This idea was mentioned by a user in the ticket, and it seems to be a sensible UI feature to me here.
