Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust vertical sizing of paste area #1766

Merged
merged 9 commits into from
Apr 1, 2024

Conversation

jotaen4tinypilot
Copy link
Contributor

@jotaen4tinypilot jotaen4tinypilot commented Mar 29, 2024

Related #1739. Stacked on #1764.

This PR adjusts slightly reduces the initial height of the paste area (from ~14 to ~10 lines), and allows the user to resize it vertically.

My thinking is that in many cases people probably only paste in short snippets (such as passwords), so the paste area wouldn’t feel as empty in this “base case”. Users can still conveniently manage longer text by resizing the paste area vertically.

Screenshot 2024-03-29 at 15 34 28

Review on CodeApprove

Copy link
Contributor

@jdeanwallace jdeanwallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved


👀 @jotaen4tinypilot it's your turn please take a look

Base automatically changed from paste/1-mask-toggle to master April 1, 2024 12:09
@jotaen4tinypilot jotaen4tinypilot merged commit 9cdb7dd into master Apr 1, 2024
14 checks passed
@jotaen4tinypilot jotaen4tinypilot deleted the paste/3-paste-area-height branch April 1, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants