Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak CSS on video settings #691

Merged
merged 2 commits into from May 14, 2021
Merged

Tweak CSS on video settings #691

merged 2 commits into from May 14, 2021

Conversation

mtlynch
Copy link
Collaborator

@mtlynch mtlynch commented May 13, 2021 •
edited

  • Make the sliders wider so that it's easier to pick precise values
  • Rename video-jpeg-quality -> video-jpeg-quality-slider
  • Rename video-fps -> video-fps-slider
  • Adjust spacing to add some more whitespace between elements
  • Fix alignment so that the sliders are vertically aligned with the text

Before

image

After

image

@mtlynch
Tweak CSS on video settings
cba5e22 
* Make the sliders wider so that it's easier to pick precise values
* Rename video-jpeg-quality -> video-jpeg-quality-slider
* Rename video-fps -> video-fps-slider
* Adjust spacing to add some more whitespace
* Fix alignment so that the sliders are vertically aligned with the text
@mtlynch mtlynch mentioned this pull request May 13, 2021
Closed
@mtlynch mtlynch requested a review from jotaen May 13, 2021 17:33
jotaen4tinypilot
jotaen4tinypilot approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@jotaen4tinypilot jotaen4tinypilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good, nice spot with the slider alignment

app/templates/custom-elements/video-settings-dialog.html Outdated Show resolved Hide resolved
jotaen
jotaen approved these changes May 14, 2021
View reviewed changes
Copy link
Contributor

@jotaen jotaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @jotaen4tinypilot haha

@mtlynch mtlynch enabled auto-merge (squash) May 14, 2021 12:08
@mtlynch mtlynch merged commit 9ec6226 into master May 14, 2021
@mtlynch mtlynch deleted the wider-vid-settings branch May 14, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotaen jotaen jotaen approved these changes

@jotaen4tinypilot jotaen4tinypilot jotaen4tinypilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtlynch @jotaen @jotaen4tinypilot