Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse generic error handling mechanism of overlay #699

Merged
merged 1 commit into from May 18, 2021

Conversation

jotaen
Copy link
Contributor

@jotaen jotaen commented May 18, 2021

I noticed that we use a custom error handling in the debug logs, but actually we have a general mechanism for errors in overlays.

@jotaen jotaen requested a review from mtlynch May 18, 2021 13:10
Copy link
Collaborator

@mtlynch mtlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jotaen jotaen merged commit 7148304 into master May 18, 2021
@jotaen jotaen deleted the debug-logs-error-handling branch May 18, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants