Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include assertions in build #62

Closed
priecint opened this issue Jul 15, 2016 · 3 comments
Closed

Don't include assertions in build #62

priecint opened this issue Jul 15, 2016 · 3 comments
Assignees

Comments

@priecint
Copy link
Contributor

assertions are only used in augur tests so there is no need to send them to browser (i.e. bundle them with UI components).

Instead of
import { assertions } from 'augur-ui-react-components';
we can have something like
import assertions from 'augur-ui-react-components/lib/assertions';

@priecint
Copy link
Contributor Author

I think the correct way how to deal with this is:
1/ add build:assertions script to package.json which builds src/assertions to lib/assertions - this would be later used in augur tests
2/ remove assertions from components.jsx

@tinybike
Copy link
Owner

Bumped to top priority (see AugurProject/augur#714 for explanation).

priecint added a commit that referenced this issue Jul 27, 2016
 - remove assertions from build
 - include assertions as lib part of AURC
 - use `files` property to include only relevant parts of AURC
priecint added a commit that referenced this issue Jul 27, 2016
priecint added a commit to AugurProject/augur-ui that referenced this issue Jul 28, 2016
 - use babel-register with ignore field
 - make market-test.js work (other will follow)
 - remove files property
 - tinybike/augur-ui-react-components#62
priecint added a commit that referenced this issue Jul 28, 2016
 - use babel-register with ignore field
 - make market-test.js work (other will follow)
 - remove files property
 - #62
priecint added a commit that referenced this issue Jul 28, 2016
@tinybike tinybike removed this from the MVP milestone Aug 4, 2016
@tinybike
Copy link
Owner

tinybike commented Aug 4, 2016

Removing this from MVP as it does not solve the npm link problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants