-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't include assertions in build #62
Labels
Comments
I think the correct way how to deal with this is: |
Bumped to top priority (see AugurProject/augur#714 for explanation). |
priecint
added a commit
that referenced
this issue
Jul 27, 2016
- remove assertions from build - include assertions as lib part of AURC - use `files` property to include only relevant parts of AURC
priecint
added a commit
to AugurProject/augur-ui
that referenced
this issue
Jul 28, 2016
- use babel-register with ignore field - make market-test.js work (other will follow) - remove files property - tinybike/augur-ui-react-components#62
priecint
added a commit
that referenced
this issue
Jul 28, 2016
- use babel-register with ignore field - make market-test.js work (other will follow) - remove files property - #62
Removing this from MVP as it does not solve the npm link problem. |
priecint
added a commit
that referenced
this issue
Aug 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
assertions
are only used in augur tests so there is no need to send them to browser (i.e. bundle them with UI components).Instead of
import { assertions } from 'augur-ui-react-components';
we can have something like
import assertions from 'augur-ui-react-components/lib/assertions';
The text was updated successfully, but these errors were encountered: