New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Android code integration documentation #152

Merged
merged 4 commits into from Jan 30, 2018

Conversation

Projects
None yet
4 participants
@slorber
Contributor

slorber commented Nov 23, 2017

No description provided.

@slorber

This comment has been minimized.

Contributor

slorber commented Nov 23, 2017

can be closed after merge: #111

@henrikra

This comment has been minimized.

Contributor

henrikra commented Nov 23, 2017

Great improvements 👍

@henrikra

This comment has been minimized.

Contributor

henrikra commented Nov 23, 2017

I would put xmlns:tools="http://schemas.android.com/tools" inside of example code of AndroidManifest so you won't miss it easily :)

README.md Outdated
import com.robinpowered.react.Intercom.IntercomPackage;
import io.intercom.android.sdk.Intercom;
public class MainApplication extends MultiDexApplication {

This comment has been minimized.

@henrikra

henrikra Nov 23, 2017

Contributor

What is this MultiDexApplication?

This comment has been minimized.

@slorber

slorber Nov 23, 2017

Contributor

Hmmm actually I don't know, it's what you get when you eject from Expo (I think multidex is used for large Android applications)

@slorber

This comment has been minimized.

Contributor

slorber commented Nov 23, 2017

@henrikra thanks for the reveiw I'e just made some changes

README.md Outdated
<?xml version="1.0" encoding="utf-8"?>
<manifest package="com.myapp"
...
xmlns:tools="http://schemas.android.com/tools"

This comment has been minimized.

@henrikra

henrikra Nov 23, 2017

Contributor

I would add comment like <!-- Add this line -->

This comment has been minimized.

@slorber

slorber Nov 23, 2017

Contributor

it wouldn't be valid xml comment imo so I prefered to put "..."

You want something like that? as you can see it breaks syntax highlighting on github so I prefered ...

<manifest package="com.myapp"
          <!-- add this line -->
          xmlns:tools="http://schemas.android.com/tools"
    >

   <!-- comment -->
</manifest>

This comment has been minimized.

@henrikra

henrikra Nov 24, 2017

Contributor

What ever works the best :D Point is that there is comment pointing what you need to add

This comment has been minimized.

@slorber

slorber Nov 24, 2017

Contributor

this could be fine like this:

image

slorber added some commits Nov 24, 2017

@mnogueron

This comment has been minimized.

mnogueron commented Jan 30, 2018

Really useful PR, hope that it will be merge soon for others! :)

@browniefed browniefed merged commit 0a8efd4 into tinycreative:master Jan 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment