improve Android code integration documentation #152
Conversation
|
can be closed after merge: #111 |
|
Great improvements 👍 |
|
I would put xmlns:tools="http://schemas.android.com/tools" inside of example code of AndroidManifest so you won't miss it easily :) |
README.md
Outdated
| import com.robinpowered.react.Intercom.IntercomPackage; | ||
| import io.intercom.android.sdk.Intercom; | ||
|
|
||
| public class MainApplication extends MultiDexApplication { |
There was a problem hiding this comment.
What is this MultiDexApplication?
There was a problem hiding this comment.
Hmmm actually I don't know, it's what you get when you eject from Expo (I think multidex is used for large Android applications)
|
@henrikra thanks for the reveiw I'e just made some changes |
README.md
Outdated
| <?xml version="1.0" encoding="utf-8"?> | ||
| <manifest package="com.myapp" | ||
| ... | ||
| xmlns:tools="http://schemas.android.com/tools" |
There was a problem hiding this comment.
I would add comment like <!-- Add this line -->
There was a problem hiding this comment.
it wouldn't be valid xml comment imo so I prefered to put "..."
You want something like that? as you can see it breaks syntax highlighting on github so I prefered ...
<manifest package="com.myapp"
<!-- add this line -->
xmlns:tools="http://schemas.android.com/tools"
>
<!-- comment -->
</manifest>There was a problem hiding this comment.
What ever works the best :D Point is that there is comment pointing what you need to add
There was a problem hiding this comment.
this could be fine like this:
|
Really useful PR, hope that it will be merge soon for others! :) |
No description provided.