Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arabic plural equation #8

Merged
merged 1 commit into from
Sep 3, 2015
Merged

Conversation

SafaAlfulaij
Copy link

Fix the plural equation.
We changed the formula to a new one years ago!

Source:
http://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html

@Grumbel
Copy link
Member

Grumbel commented Sep 3, 2015

Wouldn't it be a better idea to keep the old formula around for backwards compatibility and just add the new ones instead of replacing the old ones?

@leper
Copy link
Member

leper commented Sep 3, 2015

Judging from some of the linked documentation that change was done around 2008. All other tools we use have the proper (post this commit) plural form already.

Also applied the change downstream: http://trac.wildfiregames.com/changeset/16980

@SafaAlfulaij
Copy link
Author

@leper Thanks!
What leper said is correct, no need to keep that bad formula anymore. No one will use it, all the translation tools/websites uses the new formula right now.

Grumbel added a commit that referenced this pull request Sep 3, 2015
Fix Arabic plural equation
@Grumbel Grumbel merged commit 83c0bb8 into tinygettext:master Sep 3, 2015
KieranP pushed a commit to 0ad/0ad that referenced this pull request Sep 4, 2015
Patch by SafaAlfulaij taken from tinygettext/tinygettext#8.

git-svn-id: http://svn.wildfiregames.com/public/ps/trunk@16980 3db68df2-c116-0410-a063-a993310a9797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants