-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent version doesn't work on Debian buster #46
Comments
Also confirmed this on my laptop, running Debian buster with BlueZ 5.50 (same as the Raspberry Pi). |
I see the same thing. Ubuntu 20.04, bluez 5.53. |
Please give a try with this branch https://github.com/tinygo-org/bluetooth/tree/update-bluez-555 which updates the go-bluetooth package to the latest version with updated Bluez wrappers. |
Unfortunately, I get the exact same output as before. I also tried on Arch Linux with bluez 5.55. |
Same for me, it still doesn't work on the update-bluez-555 branch. I suspect it's because the bluetooth package assumes a newer BlueZ version. Maybe BlueZ has made a backwards incompatible change? |
I think it is something to do with changes to the wrapper generation in https://github.com/muka/go-bluetooth/commits/master/gen since the last working version, which at least on my machine is also muka/go-bluetooth@f6113f7 Note that I am testing by running "old" version of BlueZ:
If reverting to older SHA of go-bluetooth "fixes" for most of us, we should do that while we look into what might be the root cause. What does everyone think? |
I think that sounds good. Keeping on top of bluez releases is going to be a constantly moving target, so this probably won't be the last time something breaks :) Happy to try out a new branch or PR when it's available. |
A quick test shows that it doesn't crash anymore. I haven't checked whether it actually works but assuming you've tested it, LGTM. |
Unfortunately the examples are still failing for me, but now with a different error:
|
@mogenson I thought you were using Ubuntu? |
Also, you perhaps want to try 5.50:
This is the version that the recent commit downgraded to, which is, as @aykevl points out the current version on Raspian. |
Sorry for the delay. I have a Ubuntu 20.04 laptop. Just haven't used it recently.
From the dev branch:
|
@mogenson can you run this while running the program that fails?
Thanks. |
muka/go-bluetooth does some magic so you can use short UUIDs and it'll auto expand them to the full 128 bit uuid. setting these flags disables that behavior. related issues: - allows updating muka library to resolve tinygo-org#35 - fixes the regression the upgrade caused tinygo-org#46 - commit causing the regression in upstream muka/go-bluetooth@1c4c1c8
this looks like its due to muka generating invalid UUIDs if passed 128 bit uuids for a service. |
muka/go-bluetooth does some magic so you can use short UUIDs and it'll auto expand them to the full 128 bit uuid. setting these flags disables that behavior. related issues: - allows updating muka library to resolve tinygo-org#35 - fixes the regression the upgrade caused tinygo-org#46 - commit causing the regression in upstream muka/go-bluetooth@1c4c1c8
muka/go-bluetooth does some magic so you can use short UUIDs and it'll auto expand them to the full 128 bit uuid. setting these flags disables that behavior. related issues: - allows updating muka library to resolve #35 - fixes the regression the upgrade caused #46 - commit causing the regression in upstream muka/go-bluetooth@1c4c1c8
muka/go-bluetooth does some magic so you can use short UUIDs and it'll auto expand them to the full 128 bit uuid. setting these flags disables that behavior. related issues: - allows updating muka library to resolve #35 - fixes the regression the upgrade caused #46 - commit causing the regression in upstream muka/go-bluetooth@1c4c1c8
Now closing since 0.9.0 has been released. Thank you! |
This was most likely fixed with #216. |
I haven't investigated this issue yet, but I have bisected it.
Recent versions of the bluetooth package fail on the Raspberry Pi (Debian 10.4, BlueZ 5.50):
The commit introducing this is 2fb3b08, introduced in #36.
The text was updated successfully, but these errors were encountered: