linux: fix service and characteristic order #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very much like #161, but for Linux instead. In fact, I've copied the structure of the code because it works for macOS. I have tested that the scan order is now as requested. I also verified that multiple characteristics with the same UUID are now supported, but support is still a bit buggy: they appear in a random order (due to Go map iteration order). I will fix this in the next commit.
Previously the list of services and characteristics wasn't sorted, and because of the way Go maps work they were in fact randomized. This commit fixes the sorting for services and characteristics, which both suffered from the same lack of sorting. This fixes #135.
|
Thank you for the fixes @aykevl now merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #135 on Linux.
It looks like there is still a bug with DiscoverServices on both Linux and macOS (it doesn't respect the order of UUIDs given in the parameter), this should still be fixed in a separate PR.