Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compileopts: better error reporting of unsupported flags #1062

Closed
aykevl opened this issue Apr 19, 2020 · 6 comments
Closed

compileopts: better error reporting of unsupported flags #1062

aykevl opened this issue Apr 19, 2020 · 6 comments
Labels
good first issue Good for newcomers

Comments

@aykevl
Copy link
Member

aykevl commented Apr 19, 2020

There are a few flags that currently don't have proper error checking. The ones I found are -gc, -scheduler and -size. Using the wrong value will lead to no or unexpected errors.

I think the best way to handle it is to add a new method to compileopts.Config that checks whether there are any faulty flags, which is then called from the main function.
@aykevl aykevl added the good first issue Good for newcomers label Apr 19, 2020
@trevor403
Copy link

I can take this issue. I'll post a PR tomorrow.

@cebernardi cebernardi mentioned this issue Apr 26, 2020
Merged
@cebernardi
Copy link
Contributor

@trevor403 I just saw your comment here, I was "assigned" this issue on slack 19th of April..
I'm sorry we overlapped

@niaow niaow changed the title Better error reporting of unsupported flags compileopts: better error reporting of unsupported flags Apr 26, 2020
@trevor403
Copy link

That is totally okay! 😄

@deadprogram deadprogram added the next-release Will be part of next release label May 29, 2020
@niaow
Copy link
Member

niaow commented Jun 27, 2020

Has this issue been sufficiently resolved?

@aykevl
Copy link
Member Author

aykevl commented Jul 3, 2020

Yes, it will be included in the next release (see the label).

@deadprogram
Copy link
Member

This was released with v0.14.0 so now closing. Please reopen if needed. Thanks!

@deadprogram deadprogram removed the next-release Will be part of next release label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@deadprogram @aykevl @trevor403 @niaow @cebernardi