Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing flags (testVerbose/testShort/testRunRegex) should move to config.TestConfig #2406

Closed
dgryski opened this issue Dec 18, 2021 · 5 comments
Closed

testing flags (testVerbose/testShort/testRunRegex) should move to config.TestConfig #2406

dgryski opened this issue Dec 18, 2021 · 5 comments
Labels
good first issue Good for newcomers

Comments

@dgryski
Copy link
Member

dgryski commented Dec 18, 2021

I didn't see this struct was there when I added them. The struct even has a TODO to add these flags there already.
@dgryski dgryski added the good first issue Good for newcomers label Dec 18, 2021
@aykevl
Copy link
Member

aykevl commented Dec 28, 2021

To be honest, I'd say that we don't need a separate struct for this. Just put everything directly in compileopts.Config. But that's just my personal opinion (I'm not going to bikeshed about this).

@dgryski dgryski mentioned this issue Jan 12, 2022
Merged
@galamdring
Copy link

Should this be closed with the related PR merged?

@dgryski
Copy link
Member Author

dgryski commented Oct 12, 2022

The related PR is just me reminding myself in a comment that I still need to do this.

@galamdring
Copy link

galamdring commented Oct 12, 2022 via email

dgryski added a commit to dgryski/tinygo that referenced this issue Mar 31, 2023
@dgryski
main: stuff test runner options into their own struct
9f27027 
Fixes tinygo-org#2406
dgryski added a commit to dgryski/tinygo that referenced this issue Mar 31, 2023
@dgryski
main: stuff test runner options into their own struct
9ec3ab0 
Fixes tinygo-org#2406
dgryski added a commit to dgryski/tinygo that referenced this issue Mar 31, 2023
@dgryski
main: stuff test runner options into their own struct
ef371a2 
Fixes tinygo-org#2406
deadprogram pushed a commit that referenced this issue Apr 1, 2023
@dgryski @deadprogram
main: stuff test runner options into their own struct
9925097 
Fixes #2406
@aykevl aykevl added the next-release Will be part of next release label Jun 10, 2023
@aykevl
Copy link
Member

aykevl commented Jun 10, 2023

Looks like this is fixed in the dev branch.

@aykevl aykevl closed this as completed in a2f95d6 Jun 10, 2023
@deadprogram deadprogram removed the next-release Will be part of next release label Jun 14, 2023
LiuJiazheng pushed a commit to LiuJiazheng/tinygo that referenced this issue Aug 20, 2023
@dgryski @LiuJiazheng
main: stuff test runner options into their own struct
6342560 
Fixes tinygo-org#2406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@deadprogram @aykevl @dgryski @galamdring