Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: on clean systems, git submodule update --init can have authn issues #3856

Closed
kenbell opened this issue Aug 7, 2023 · 1 comment
Closed

dev: on clean systems, git submodule update --init can have authn issues #3856

kenbell opened this issue Aug 7, 2023 · 1 comment

Comments

@kenbell
Copy link
Member

kenbell commented Aug 7, 2023

The new renesas SVD submodule has an SSH 'URL' unlike the other submodules which are HTTPS. This can lead to public key errors (repro case unclear).

We should use an HTTPS url for this submodule, the same as other submodules.
kenbell added a commit that referenced this issue Aug 7, 2023
@kenbell
all: use https for renesas submodule #3856
6b1692b
@kenbell kenbell mentioned this issue Aug 7, 2023
Merged
deadprogram pushed a commit that referenced this issue Aug 7, 2023
@kenbell @deadprogram
all: use https for renesas submodule #3856
72270f9
@deadprogram
Copy link
Member

deadprogram commented Aug 7, 2023 •
edited

Since the Renesas submodule was merged only in the current dev branch, now closing this. Thanks @kenbell for the fix!

This was referenced Aug 25, 2023
Closed
Closed
deadprogram pushed a commit that referenced this issue Sep 17, 2023
@kenbell @deadprogram
all: use https for renesas submodule #3856
6e7cbf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deadprogram @kenbell