Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtime stubs required for net/http #1912

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

fgsch
Copy link
Contributor

@fgsch fgsch commented May 28, 2021

Continued from #1911.

@fgsch fgsch changed the title Add runtime stubs for net/http Add runtime stubs required for net/http May 28, 2021
@fgsch fgsch force-pushed the fgsch/runtime-stubs branch 2 times, most recently from b9d9fb9 to 2ab5969 Compare May 28, 2021 16:39
@deadprogram
Copy link
Member

I do not know enough about this part of runtime to really comment.

Copy link
Member

@sago35 sago35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aykevl aykevl merged commit 62f9f61 into tinygo-org:dev Jun 1, 2021
@aykevl
Copy link
Member

aykevl commented Jun 1, 2021

Looks reasonable to me. I'm sure I've written this code before but apparently never made a PR for it.

@fgsch fgsch deleted the fgsch/runtime-stubs branch June 2, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants