reflect: Add Value.IsZero() method #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Value.IsZero() with tests, largely copied from the Go source code. The tests were altered to remove the parts calling `Zero()` as that is still unimplemented in tinygo, and to remove a test that tries to catch a panic which is not supported on wasi. A new case for `UnsafePointer` in `Value.IsNil()` was required for unsafe.Pointer tests to pass. Link: https://cs.opensource.google/go/go/+/refs/tags/go1.19.3:src/reflect/value.go;l=1568 Link: https://cs.opensource.google/go/go/+/refs/tags/go1.19.3:src/reflect/all_test.go;l=1322 Co-authored-by: Cam Hutchison <camh@xdna.net>
|
Thank you very much for the improvement @juliaogris and thanks @dgryski for reviewing. Now merging. |
1 similar comment
|
Thank you very much for the improvement @juliaogris and thanks @dgryski for reviewing. Now merging. |
|
Also thanks @camh- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Value.IsZero()with tests, largely copied from the Go source code.The tests were altered to remove the parts calling
Zero()as that isstill unimplemented in tinygo, and to remove a test that tries to catch
a panic which is not supported on wasi.
A new case for
UnsafePointerinValue.IsNil()was required for unsafe.Pointer tests to pass.Link: https://cs.opensource.google/go/go/+/refs/tags/go1.19.3:src/reflect/value.go;l=1568
Link: https://cs.opensource.google/go/go/+/refs/tags/go1.19.3:src/reflect/all_test.go;l=1322
Co-authored-by: Cam Hutchison camh@xdna.net