Filter target build-tags if user specified an overriding option #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me @anuraaga just wondering if you could perhaps write a test for the new function? I realize that the |
|
Sorry for the huge delay, finally added unit tests |
deadprogram
approved these changes
Feb 14, 2023
|
Now going to squash/merge. Thanks @anuraaga |
waj334
pushed a commit
to waj334/tinygo
that referenced
this pull request
Feb 24, 2023
…go-org#3357) compileopts: Filter target build-tags if user specified an overriding option
conejoninja
pushed a commit
to conejoninja/tinygo
that referenced
this pull request
Mar 22, 2023
…go-org#3357) compileopts: Filter target build-tags if user specified an overriding option
deadprogram
pushed a commit
that referenced
this pull request
Mar 28, 2023
compileopts: Filter target build-tags if user specified an overriding option
aykevl
added a commit
that referenced
this pull request
May 13, 2023
This basically reverts #3357 and replaces it with a different mechanism to get to the same goal. I do not think filtering tags like this is a good idea: it's the wrong part of the compiler to be concerned with such tags (that part sets tags, but doesn't modify existing tags). Instead, I've written the //go:build lines in such a way that it has the same effect: WASI defaults to leveldb, everything else defaults to fnv, and it's possible to override the default using build tags.
aykevl
added a commit
that referenced
this pull request
May 13, 2023
This basically reverts #3357 and replaces it with a different mechanism to get to the same goal. I do not think filtering tags like this is a good idea: it's the wrong part of the compiler to be concerned with such tags (that part sets tags, but doesn't modify existing tags). Instead, I've written the //go:build lines in such a way that it has the same effect: WASI defaults to leveldb, everything else defaults to fnv, and it's possible to override the default using build tags.
deadprogram
pushed a commit
that referenced
this pull request
May 17, 2023
This basically reverts #3357 and replaces it with a different mechanism to get to the same goal. I do not think filtering tags like this is a good idea: it's the wrong part of the compiler to be concerned with such tags (that part sets tags, but doesn't modify existing tags). Instead, I've written the //go:build lines in such a way that it has the same effect: WASI defaults to leveldb, everything else defaults to fnv, and it's possible to override the default using build tags.
LiuJiazheng
pushed a commit
to LiuJiazheng/tinygo
that referenced
this pull request
Aug 20, 2023
…go-org#3357) compileopts: Filter target build-tags if user specified an overriding option
LiuJiazheng
pushed a commit
to LiuJiazheng/tinygo
that referenced
this pull request
Aug 20, 2023
This basically reverts tinygo-org#3357 and replaces it with a different mechanism to get to the same goal. I do not think filtering tags like this is a good idea: it's the wrong part of the compiler to be concerned with such tags (that part sets tags, but doesn't modify existing tags). Instead, I've written the //go:build lines in such a way that it has the same effect: WASI defaults to leveldb, everything else defaults to fnv, and it's possible to override the default using build tags.
deadprogram
pushed a commit
that referenced
this pull request
Sep 17, 2023
This basically reverts #3357 and replaces it with a different mechanism to get to the same goal. I do not think filtering tags like this is a good idea: it's the wrong part of the compiler to be concerned with such tags (that part sets tags, but doesn't modify existing tags). Instead, I've written the //go:build lines in such a way that it has the same effect: WASI defaults to leveldb, everything else defaults to fnv, and it's possible to override the default using build tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when building for wasi, the
runtime_memhash_option cannot be overridden because the leveldb option always gets added, but only one file is allowed to be compiled