Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/windows: trying to increase stack size for bash/make #3523

Closed
wants to merge 1 commit into from

Conversation

deadprogram
Copy link
Member

This PR attempts to increase stack size for bash/make.

See microsoft/WSL#633 and actions/runner-images#3738

Signed-off-by: deadprogram <ron@hybridgroup.com>
@deadprogram
Copy link
Member Author

Not going to work this way. Closing until I come up with another idea.

@deadprogram deadprogram closed this Mar 6, 2023
@deadprogram deadprogram deleted the more-windows-stack-size branch March 6, 2023 11:25
@aykevl
Copy link
Member

aykevl commented Mar 6, 2023

I'm 95% sure the stack is not the issue, but rather some sort of race condition (probably that we don't have threads enabled, see #3130).
If the issue was a small stack, then it would segfault, not log a warning sometimes.

I wonder how big the stacks actually are though, because it can't be 8kB - that's way too small, and we probably would have seen many segfaults if it were that small. (For reference, we already ran into problems with a 128kB stack on Alpine Linux).

@aykevl
Copy link
Member

aykevl commented Mar 6, 2023

Here is why:

static LLVM_THREAD_LOCAL void *BottomOfStack = nullptr;

If we're compiling with threads disabled on Windows, I doubt this is actually a thread local variable and it will cause chaos if two threads are setting their own bottom of stack. Probably the reason this doesn't trigger all the time is that there is a heuristic in the stack check for unexpected values, and usually the stacks aren't close enough to trigger it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants