machine.UART refactor #3832
Merged
machine.UART refactor #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Looks good to me.
This may break some application that assumed the previous incorrect behavior, but it is certainly an improvement over what we had previously.
We might want to do something similar for ReadByte: at the moment it does not block while the vast majority of applications need a blocking interface.
kenbell
reviewed
Jul 14, 2023
|
One of the jobs failed- maybe a flaky build? @deadprogram @aykevl |
|
OK, the flaky test passed. Merging now. Thank you everyone for the great feedback! |
deadprogram
pushed a commit
that referenced
this pull request
Jul 18, 2023
* add gosched calls to UART * add UART.flush() stubs for all supported architectures * add comment un uart.go on flush functionality * uart.writeByte as base of UART usage * fix NXP having duplicate WriteByte * fix writeByte not returning error on some platforms * add flush method for fe310 device * check for error in WriteByte call to writeByte
This was referenced Aug 25, 2023
deadprogram
pushed a commit
that referenced
this pull request
Sep 17, 2023
* add gosched calls to UART * add UART.flush() stubs for all supported architectures * add comment un uart.go on flush functionality * uart.writeByte as base of UART usage * fix NXP having duplicate WriteByte * fix writeByte not returning error on some platforms * add flush method for fe310 device * check for error in WriteByte call to writeByte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3537, closes #3538.
Adds:
UART.flush: method implemented by UARTs that blocks until all data has finished being transmitteduart.writeByte: method implemented by UARTs that writes over the UART pin without blocking.Semantic changes:
UART.WriteByteandUART.Write: Methods now expected to block until all data has been finished being transmitted over wire.