cgo: implement #cgo CFLAGS #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykevl
force-pushed
the
cgo-flags
branch
2 times, most recently
from
3acc42f
to
e52ae75
Compare
|
Hi @aykevl looks like getting this to work on Windows is going to require some additional effort, in case you did notice that the build had failed. |
|
I thought I fixed it but apparently not. Trying again. |
aykevl
force-pushed
the
cgo-flags
branch
5 times, most recently
from
94d790f
to
6b93bea
Compare
|
Looks like I'm hitting a bug (or feature?) of the |
This commit adds tests for CGo preprocessing. There are various errors that can be reported while preprocessing, and they should integrate well with the compiler (including accurate source location tracking). Also allow CGo preprocessing to continue after Clang encountered an error, for a better view of what happened.
This implementation is still very limited but provides a base to build upon. Limitations: * CGO_CFLAGS etc is not taken into account. * These CFLAGS are not used in C files compiled with the package. * Other flags (CPPFLAGS, LDFAGS, ...) are not yet implemented.
|
Managed to find a workaround. This is ready for review again. |
|
It took a little longer to review this as it is rather complex. This is a great example of how important tests are to communicate intent. Merging, great work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is still very limited but provides a base to build upon. Limitations:
CGO_CFLAGSetc is not taken into account.CFLAGSare not used in C files compiled with the package.CPPFLAGS,LDFAGS, ...) are not yet implemented.