Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requires_grad check for replace and assign #3880

Closed
wants to merge 5 commits into from
Closed

Remove requires_grad check for replace and assign #3880

wants to merge 5 commits into from

Commits on Mar 22, 2024

  1. Remove requires_grad check for replace and assign

    @eugeneteoh
    eugeneteoh committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    1528558 View commit details
    Browse the repository at this point in the history

  2. Add test for replace and assign

    @eugeneteoh
    eugeneteoh committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    a180eb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Set requires_grad for replace and assign; add test to check gradients

    @eugeneteoh
    eugeneteoh committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    a49a550 View commit details
    Browse the repository at this point in the history

  2. Remove setting requires_grad for assign

    @eugeneteoh
    eugeneteoh committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    10188a7 View commit details
    Browse the repository at this point in the history

  3. Add one more assert

    @eugeneteoh
    eugeneteoh committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    f3c8b4a View commit details
    Browse the repository at this point in the history