fix HSA/KFD load for system-wide installation #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ohh you actually generate hsa and compgr files. Hmmm I will fix it. |
nimlgen
reviewed
Apr 19, 2024
|
We are going to replace HSA with KFD soon anyway. |
seems like for KFD we still need libamd_comgr.so |
stalkerg
force-pushed
the
bugfix/load-hsa
branch
from
3ac843b
to
8a20dbe
Compare
|
@nimlgen can you check again? Thank you. |
stalkerg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fix for a such issue: #4168
Some distros like Gentoo install HSA and ROCm libs as system-wide libraries instead
/optdirectory.ROCM_PATH is more like build-time path, for runtime discovery better to use
find_libraryespecially if ROCM_PATH not here.It's also will work if follow official ROCm instruction https://rocm.docs.amd.com/projects/install-on-linux/en/latest/how-to/native-install/post-install.html