Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fusion tests from test_opt #4357

Merged
merged 4 commits into from
May 1, 2024
Merged

fusion tests from test_opt #4357

merged 4 commits into from
May 1, 2024

Conversation

Qazalin
Copy link
Collaborator

@Qazalin Qazalin commented Apr 30, 2024

test_llama remains in external_test_opt because model.forward calls realize internally.

Copy link
Contributor

github-actions bot commented May 1, 2024

This branch currently is behind tinygrad/master. The line count difference bot is disabled.

@Qazalin Qazalin changed the title inference kernel counts in test_schedule fusion tests from test_opt May 1, 2024
@Qazalin
Copy link
Collaborator Author

Qazalin commented May 1, 2024

The models tests take the longest:

1.33s call     test/test_schedule.py::TestSchedule::test_enet
1.25s call     test/test_schedule.py::TestSchedule::test_enet_se
1.17s call     test/test_schedule.py::TestSchedule::test_convnext
0.97s call     test/test_schedule.py::TestSchedule::test_resnet
0.64s call     test/test_schedule.py::TestSchedule::test_vit

I think we can keep them in external_test_opt.py and run once in GPU=1.

This picks the the more specific fusion tests from external_test_opt.

@@ -165,103 +164,6 @@ def test_muladd(self):
d.realize()
np.testing.assert_allclose(d.numpy(), na*nb+nc, rtol=1e-5, atol=1e-7)

def test_fold_reduce_elementwise(self):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in test_schedule "fold" is "fuse" for consistency.

@Qazalin Qazalin marked this pull request as ready for review May 1, 2024 13:43
@Qazalin Qazalin merged commit ea06f65 into tinygrad:master May 1, 2024
16 checks passed
@Qazalin Qazalin deleted the test-opt branch May 1, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant