Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for etag #133

Closed
9 tasks
talentlessguy opened this issue Oct 7, 2020 · 2 comments
Closed
9 tasks

Write tests for etag #133

talentlessguy opened this issue Oct 7, 2020 · 2 comments
Assignees
@MaurizioPz
Labels
easy good first issue Good for newcomers tests

Comments

@talentlessguy
Copy link
Member

talentlessguy commented Oct 7, 2020 •
edited

there are some tests written for etag already, but there needs to be more of them:

  • should reject number entities
  • Buffer
    • should work for empty buffer
    • should generate a strong ETag
  • fs.Stats
    • should generate a weak ETag
  • weak option
    • should generate a strong eTag when is set to false
    • should generate a weak eTag when set to true
@talentlessguy talentlessguy mentioned this issue Oct 7, 2020
Open
30 tasks
@MaurizioPz
Copy link
Contributor

great

@MaurizioPz MaurizioPz mentioned this issue Oct 7, 2020
Merged
talentlessguy pushed a commit that referenced this issue Oct 8, 2020
Merge pull request #137 from MaurizioPz/#133
d1b0442 
Added tests for ETag
@talentlessguy
Copy link
Member Author

Closed via #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaurizioPz MaurizioPz

Labels
easy good first issue Good for newcomers tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MaurizioPz @talentlessguy