-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#140 added tests for req #142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
+ Coverage 68.43% 68.60% +0.17%
==========================================
Files 49 49
Lines 1752 1752
Branches 441 441
==========================================
+ Hits 1199 1202 +3
+ Misses 552 549 -3
Partials 1 1
Continue to review full report at Codecov.
|
@MaurizioPz by "should ignore charset" for |
Well than there's a bug right now, because it sounds like you are expecting this test to pass and it doesn't
|
@MaurizioPz i've investigated on the issue and pointed it out in #150. You can work on it if you want as it is very easy to fix but also relatively important. |
@MaurizioPz could you pls fix the conflict so we can merge this? |
# Conflicts: # __tests__/modules/req.test.ts
nice, now it looks good merging |
@all-contributors add @MaurizioPz for test |
I've put up a pull request to add @MaurizioPz! 🎉 |
This PR adds the test listed on #140
but the test 'Should ignore charset' is ignored because right now it doesn't pass. I may have misinterpreted the desired test, but as of right now https://github.com/jshttp/media-typer seems to be using a regex that doesn't handle charset