Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): pass req.params to next handler #315

Merged
merged 4 commits into from
Sep 17, 2021
Merged

fix(core): pass req.params to next handler #315

merged 4 commits into from
Sep 17, 2021

Conversation

esthedebeste
Copy link
Contributor

Also modified tests to check req.params
Closes #314

@talentlessguy
Copy link
Member

LGTM, could you also run pnpm chgset for the package you fixed bug in?

@esthedebeste
Copy link
Contributor Author

👍 done

@talentlessguy
Copy link
Member

I think you forgot to run pnpm chgset to bump a package's version

@esthedebeste
Copy link
Contributor Author

not sure how chgset works, i think i did right? it made a clever-camels-relate file 🤷

@talentlessguy
Copy link
Member

@tbhmens you should select a patch version update in pnpm chgset for @/app

@esthedebeste
Copy link
Contributor Author

pretty sure i did that, 6922256

@talentlessguy
Copy link
Member

package.json file hasn't changed

@esthedebeste
Copy link
Contributor Author

ohh, the chgset command might've ran wrong or something. 👍 fixed

@talentlessguy
Copy link
Member

thanks! and sorry for inconvenience, changesets is sometimes buggy

@talentlessguy talentlessguy merged commit 4bf97c7 into tinyhttp:master Sep 17, 2021
@talentlessguy
Copy link
Member

@all-contributors add @tbhmens for bug, code

@allcontributors
Copy link
Contributor

@talentlessguy

I've put up a pull request to add @tbhmens! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subapps not receiving params from parent apps
2 participants