Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow mounting of sub-app on root #329

Merged
merged 1 commit into from
Oct 28, 2021
Merged

fix: Allow mounting of sub-app on root #329

merged 1 commit into from
Oct 28, 2021

Conversation

tomhooijenga
Copy link
Contributor

This should fix #279.

Somehow there was a huge difference between app.use('/', subApp) and app.use('/path', subApp).

@talentlessguy
Copy link
Member

does it work with other mountpaths if two apps are mounted on same root?

@tomhooijenga
Copy link
Contributor Author

Do you mean like this?

app.use('/abc', subApp1);
app.use('/abc', subApp2);

This is covered in this test and still works :)

@talentlessguy
Copy link
Member

oh nice, then then I'll merge it after CI passes :D

@talentlessguy talentlessguy merged commit 47be7fe into tinyhttp:master Oct 28, 2021
@talentlessguy
Copy link
Member

@all-contributors add @tomhooijenga to code

@allcontributors
Copy link
Contributor

@talentlessguy

I've put up a pull request to add @tomhooijenga! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple sub-apps mounted on the same route result in Not Found for further subapps
2 participants