skip empty event #55
skip empty event #55
Conversation
| throw new Error('should not be called'); | ||
| }); | ||
|
|
||
| bench.remove('non-existent'); |
There was a problem hiding this comment.
check how vitest tests for non throwing.
There was a problem hiding this comment.
No errors, just an empty event received in the listener
There was a problem hiding this comment.
There is expect.unreachable() for situations like this
There was a problem hiding this comment.
Approval required to update version for "vitest"
There was a problem hiding this comment.
Update to latest vitest if necessary
|
The question, which has to be discussed before hand is, if it makes sense to ignore the non existing task, or to throw a custom error. |
Co-authored-by: Uzlopak <aras.abbasi@googlemail.com>
|
I don't have much respect for throwing errors |
|
with returning |
|
are you sure adding |
Fixes: #54