Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove DOM-related types to make tinybench environment agnostic #58

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: remove DOM-related types to make tinybench environment agnostic #58

merged 1 commit into from
Oct 4, 2023

Conversation

sheremet-va
Copy link
Member

No description provided.

AriPerkkio
AriPerkkio approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this project's codebase, but I did some testing in minimal repro with @types/nodes and another with lib: ["dom"] and both seem to work correctly with AddEventListenerOptionsArgument. 馃憤

@Aslemammad Aslemammad merged commit d78e6a5 into tinylibs:main Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriPerkkio AriPerkkio AriPerkkio approved these changes

@Aslemammad Aslemammad Aslemammad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sheremet-va @AriPerkkio @Aslemammad