-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overloaded "isEnabled" method that takes loggerClassName instead of callerDepth (#381) #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2.7 #383 +/- ##
=========================================
Coverage 94.54% 94.54%
- Complexity 2773 2783 +10
=========================================
Files 140 140
Lines 5422 5428 +6
Branches 710 711 +1
=========================================
+ Hits 5126 5132 +6
Misses 164 164
Partials 132 132
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pmwmedia
requested changes
Feb 26, 2023
tinylog-api/src/test/java/org/tinylog/provider/BundleLoggingProviderTest.java
Outdated
Show resolved
Hide resolved
tinylog-api/src/test/java/org/tinylog/provider/BundleLoggingProviderTest.java
Outdated
Show resolved
Hide resolved
tinylog-api/src/test/java/org/tinylog/provider/NopLoggingProviderTest.java
Outdated
Show resolved
Hide resolved
tinylog-api/src/test/java/org/tinylog/provider/NopLoggingProviderTest.java
Outdated
Show resolved
Hide resolved
…#381) updated per PR review
pmwmedia
requested changes
Feb 26, 2023
tinylog-api/src/test/java/org/tinylog/provider/BundleLoggingProviderTest.java
Outdated
Show resolved
Hide resolved
…#381) updated per PR review
pmwmedia
approved these changes
Feb 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great PR!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue:
#381