Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overloaded "isEnabled" method that takes loggerClassName instead of callerDepth (#381) #383

Merged
merged 6 commits into from
Feb 26, 2023

Conversation

q3769
Copy link
Contributor

@q3769 q3769 commented Feb 23, 2023

Description

Linked issue:

#381

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #383 (3374d95) into v2.7 (5ac1045) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               v2.7     #383   +/-   ##
=========================================
  Coverage     94.54%   94.54%           
- Complexity     2773     2783   +10     
=========================================
  Files           140      140           
  Lines          5422     5428    +6     
  Branches        710      711    +1     
=========================================
+ Hits           5126     5132    +6     
  Misses          164      164           
  Partials        132      132           
Impacted Files Coverage Δ
...va/org/tinylog/provider/BundleLoggingProvider.java 100.00% <100.00%> (ø)
.../java/org/tinylog/provider/NopLoggingProvider.java 100.00% <100.00%> (ø)
.../java/org/tinylog/core/TinylogLoggingProvider.java 96.69% <100.00%> (-0.03%) ⬇️
...rg/tinylog/adapter/jboss/JBossLoggingProvider.java 87.50% <100.00%> (+0.40%) ⬆️
...g/tinylog/adapter/jul/JavaUtilLoggingProvider.java 88.57% <100.00%> (+0.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@q3769 q3769 requested a review from pmwmedia February 26, 2023 20:25
@pmwmedia pmwmedia changed the title add overloaded "isEnabled" method that takes loggerClassName instead of callerDepth (#381) Add overloaded "isEnabled" method that takes loggerClassName instead of callerDepth (#381) Feb 26, 2023
@q3769 q3769 requested a review from pmwmedia February 26, 2023 22:26
Copy link
Member

@pmwmedia pmwmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great PR!

@pmwmedia pmwmedia merged commit ce940d1 into tinylog-org:v2.7 Feb 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants