DOC-1008: Configuration tool #2176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerkelly13
requested review from
a team,
jscasca,
EkimChau and
tiny-james
and removed request for
a team
lnewson
reviewed
Nov 22, 2021
| <div id="configurator"> | ||
| </div> | ||
| <script src="https://cdn.tiny.cloud/1/qagffr3pkuv17a8on1afax661irst1hbr4e6tbv888sz91jc/tinymce/5/tinymce.min.js" referrerpolicy="origin"></script> | ||
| <script src="../js/configurator/configurator.js" referrerpolicy="origin"></script> |
There was a problem hiding this comment.
Why is this getting embedded on the docs site? That is a really bad idea and this should be hosted by actual infrastructure similar to the skin tool.
lnewson
suggested changes
Nov 30, 2021
There was a problem hiding this comment.
Marking as needs changes as this tool shouldn't be deployed on the docs, it should be handled by the website team or at least deployed on a separate domain/path as I mentioned in a previous comment.
Edit: To clarify, I don't mind embedding it via an iframe, but the tool itself cannot be under the /docs/ path.
EkimChau
approved these changes
Nov 30, 2021
tylerkelly13
force-pushed
the
feature/realm
branch
from
7b55d43
to
76902d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: DOC-1008
Description of Changes:
Add Skin tool pagePre-checks:
feature/orhotfix/_data/nav.ymlhas been updated (if applicable)Review: