Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force not to load plugins dynamically? #3500

Closed
AlecTaylor opened this issue Feb 21, 2017 · 7 comments
Closed

Force not to load plugins dynamically? #3500

AlecTaylor opened this issue Feb 21, 2017 · 7 comments
Labels
status: escalated type: bug

Comments

@AlecTaylor
Copy link

Do you want to request a feature or report a bug?
Feature

What is the current behavior?
TinyMCE gives a bunch of 404s for http://localhost:4200/skins/lightgray/skin.min.css &etc.

**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via fiddle.tinymce.com or similar.

What is the expected behavior?
I've minified all the .css and .js files. TinyMCE loads just fine. Now I want to get rid of the 404s; as visible in the console/network tabs.

Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE?
Looks like this has been wanted since at least 2014: http://stackoverflow.com/a/26658959
@fyrkant
Copy link

fyrkant commented Feb 22, 2017

Have you set the skin_url option correctly?

@AlecTaylor
Copy link
Author

@fyrkant well my skin_url is currently set, however it is looking for specific .css files within there.

Whereas I have already loaded those .css files in my bundle. So I just want it to not try to dynamically load anything (as both JS and CSS have already been loaded outside TinyMCE).

@donShakespeare
Copy link

If you have already loaded the CSS try:
skin_url: 'path/to/own/empty/skin

Wishful thinking

It would be good if we had
plugin_url: '/basepath/to/own/stuff/'

Or force default plugins to load via
external_plugins

@fyrkant
Copy link

fyrkant commented Feb 27, 2017

@AlecTaylor Have you tried setting skin: false? I think should be possible to disable the loading of the normal skin files.

@vupham2909
Copy link

@fyrkant I having the same issue as @AlecTaylor said that TinyMCE keep appending stylesheet skin.min.css and content.inline.min.css link to <head> every time a editor init. If we have many editors on a same page then these pair of stylesheet links keep appending manytime.
I also tried setting skin: false but appear to me that this setting make return a default skin location url : /skins/lightgray/ instead of disable the loading of normal skin files.
Any suggestion to disable to not load these files dynamically in case these styles are bundled and already loaded ?

@vupham2909 vupham2909 mentioned this issue Jul 14, 2017
Closed
@vupham2909 vupham2909 mentioned this issue Aug 1, 2017
Closed
@gauthierm
Copy link

skin: false seems to work in the latest release.

@lnewson
Copy link
Contributor

lnewson commented May 8, 2020

As noted above this appear to have been fixed, as I'm unable to reproduce the issue in the latest versions of TinyMCE. Looking back at the changelog it appears this issue was fixed in TinyMCE 4.7.2, so I'm going to close this. However, if you're still experiencing issues then let us know and we'll reopen this issue.

Thanks!

@lnewson lnewson closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: escalated type: bug
Projects
None yet
Milestone
No milestone
6 participants
@gauthierm @AlecTaylor @lnewson @vupham2909 @donShakespeare @fyrkant