Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mceInsertRawHTML is broken since 4.7.10 #4401

Closed
mwilliamson opened this issue May 18, 2018 · 2 comments
Closed

mceInsertRawHTML is broken since 4.7.10 #4401

mwilliamson opened this issue May 18, 2018 · 2 comments

Comments

@mwilliamson
Copy link

Do you want to request a feature or report a bug?

Bug

What is the current behavior?

editor.execCommand('mceInsertRawHTML', false, text); does nothing

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via fiddle.tinymce.com or similar.

http://fiddle.tinymce.com/3sgaab

What is the expected behavior?

editor.execCommand('mceInsertRawHTML', false, html); inserts the specified HTML.

Which versions of TinyMCE, and which browser / OS are affected by this issue? Did this work in previous versions of TinyMCE?

This seems to be broken since 4.7.10. I've tried it in Firefox, and had reports of the issue in Chrome.

I think this change is the issue: 94c6a98#diff-ad701515834368d8523e5034df87394eR451

Specifically, content is assigned before setSelection is called, whereas it seems to me that content should be assigned after setSelection.

@jekuer
Copy link

jekuer commented Aug 8, 2018

Any updates on this?
Commit is still not accepted

@TheSpyder
Copy link
Member

Should be fixed with #4625

TheSpyder pushed a commit that referenced this issue Nov 30, 2018
* origin/5.x: (23 commits)
  Jenkins bump to 5.0.0-preview-3-build.1
  Bump to preview 3
  Jenkins bump to 5.0.0-preview-2-build.8
  Decided to call this preview 3 officially
  Changelog about toolbar groups
  AP-404: Remove unnecessary argument from silver renderUI to avoid confusion
  AP-404: add changelog
  targetNode is no longer passed through to render
  Jenkins bump to 5.0.0-preview-2-build.7
  Test fixes for Jenkins
  Test fixes for Jenkins
  Jenkins bump to 5.0.0-preview-2-build.6
  Fix tsc problem for Jenkins
  AP-324 Fix bugs with editor sizing and change editor layout to use modern CSS, not manual size calculations
  fix typing errors caused by sand typing
  Fixed the mceInsertRawHTML editor command #4401, as per mwilliamson's suggestion
  TINY-1877: added support for html5 main element
  Need to use content doc for annotation markers
  TBS-2449: extra bracket in comment
  TBS-2449: more detail to comment
  ...
TheSpyder pushed a commit that referenced this issue Nov 30, 2018
* origin/5.x: (23 commits)
  Jenkins bump to 5.0.0-preview-3-build.1
  Bump to preview 3
  Jenkins bump to 5.0.0-preview-2-build.8
  Decided to call this preview 3 officially
  Changelog about toolbar groups
  AP-404: Remove unnecessary argument from silver renderUI to avoid confusion
  AP-404: add changelog
  targetNode is no longer passed through to render
  Jenkins bump to 5.0.0-preview-2-build.7
  Test fixes for Jenkins
  Test fixes for Jenkins
  Jenkins bump to 5.0.0-preview-2-build.6
  Fix tsc problem for Jenkins
  AP-324 Fix bugs with editor sizing and change editor layout to use modern CSS, not manual size calculations
  fix typing errors caused by sand typing
  Fixed the mceInsertRawHTML editor command #4401, as per mwilliamson's suggestion
  TINY-1877: added support for html5 main element
  Need to use content doc for annotation markers
  TBS-2449: extra bracket in comment
  TBS-2449: more detail to comment
  ...

# Conflicts:
#	changelog.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants