Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowerscore on tag name bug #632

Closed
TinyMCE-User opened this issue Apr 26, 2013 · 2 comments
Closed

Lowerscore on tag name bug #632

TinyMCE-User opened this issue Apr 26, 2013 · 2 comments

Comments

@TinyMCE-User
Copy link

Description of problem:
TinyMCE seems to break when you use a custom tag that contains a lowerscore.
E.g. The syntax should look like
&ltg;custom_tag>My contents&ltg;/custom_tag>

When TinyMCE renders the underlying HTML, it displays something like this:
&ltg;custom_tag>My contents

Instead of just showing the text within the tag.

Steps to reproduce:

  1. Visit TinyMCE home where there is a live editor:
    http://www.tinymce.com/index.php
  2. Edit the source code and paste this tag &ltg;custom_tag>My contents&ltg;/custom_tag>
  3. Click the GO button and see how TinyMCE renders the HTML.
  4. This only happens when there is a lowerscore in the tagname, it does not happen in any other situation, e.g. you can use mid-scores or other special characters, but the lowerscore seems the culprit.

Expected result:
It should display :
My contents

Actual result:
It displays:
&ltg;custom_tag>My contents

Legacy information imported from TinyMCE bug tracker:

#T5843 posted by TheAgux

Tags: [chrome custom tags]
Status: Open
Resolution: None
Attached URL: none

@TinyMCE-User
Copy link
Author

I believe I found it in the TinyMCE source code, it might be good to implement it...

It is near the line with the comment

// Precompile RegExps and map objects

The "Start Element" regex has this prefix:
(?:([A-Za-z0-9-:]+)

It's a matter of adding the lowerscore to the list, like this:
(?:([A-Za-z0-9-:_]+)

It fixed it in my environment :) And I feel like a hero :)

Posted by TheAgux

@metricjs
Copy link
Contributor

Hi, we've investigated this issue and cannot reproduce it in TinyMCE v4.4.0. Thanks, the TinyMCE Team.

spocke added a commit that referenced this issue Jun 11, 2018
* commit '48b96a78aaafdf212023d9ab0c4057ef33cee8f5':
  TINY-1720: lock boulder for breaking changes
  TINY-1720: lockdown alloy for breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants