Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ShadowDOM] add invalid_classes setting #4800

Closed

Conversation

mdgbayly
Copy link

Add an invalid_classes setting similar to invalid_styles etc.

This was added to make it easy to remove the scope classes added by ShadyCSS when using tinymce in an encapsulated shadow root.

@metricjs
Copy link
Contributor

Thanks @mdgbayly for this PR! We have discussed it with the team and would like to accept it. However, due to the age it is in an unmergeable state. Would you like to rebase it on the latest develop branch, then we can review it properly? You will also need to agree to our CLA for us to be able to merge it. We have re-sent the CLA email - please follow the instructions within it to sign the CLA. If you can't find it, please check your spam folder.

@mdgbayly
Copy link
Author

mdgbayly commented Dec 8, 2020

Closing because I don't have time to rebase this, and it may no longer be required from our perspective if we are able to switch to a version of tinymce that has better support for shadow DOM etc. I understand this is still an ongoing area of discussion particularly for inline editors. But without that support etc, by itself this PR doesn't give us much. If it's deemed a useful feature regardless by the tinymce team, more than happy for you guys to just run with it yourself. Thanks!

@mdgbayly mdgbayly closed this Dec 8, 2020
@metricjs
Copy link
Contributor

metricjs commented Dec 9, 2020

Thanks for the update! This feature does make sense, even separate to Shadow DOM support, so I've made a note internally to revisit the idea in the future. And if you do find it is required later, please feel free to make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants