New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TINY-6475: Fixed incorrect Tools
types and added types to ArrUtils
#6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnewson
requested review from
ashfordneil,
HAFRMO,
ltrouton,
metricjs,
SimonFc and
spocke
as code owners
October 1, 2020 01:52
lnewson
commented
Oct 1, 2020
lnewson
force-pushed
the
TINY-6475
branch
2 times, most recently
from
October 1, 2020 02:26
61121d1
to
9b0c417
Compare
ashfordneil
approved these changes
Oct 1, 2020
metricjs
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked into a couple things that felt odd, but they seem to all be existing implementation quirks. Otherwise LGTM with the recent changes.
ltrouton
approved these changes
Oct 1, 2020
HAFRMO
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: TINY-6475
Description of Changes:
Tools
API. Note given the time constraints a lot of places have just been updated to useany
for now. Also if you seeinterface
converted totype
it's because the type needs to be iterable.Pre-checks:
Tests have been added (if applicable)Branch prefixed withfeature/
for new features (if applicable)License headers added on new files (if applicable)Review:
GitHub issues (if applicable):