Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TINY-6475: Fixed incorrect Tools types and added types to ArrUtils #6073

Merged
merged 2 commits into from Oct 1, 2020

Conversation

lnewson
Copy link
Contributor

@lnewson lnewson commented Oct 1, 2020

Related Ticket: TINY-6475

Description of Changes:

  • Fixes incorrect types discovered in the Tools API. Note given the time constraints a lot of places have just been updated to use any for now. Also if you see interface converted to type it's because the type needs to be iterable.

Pre-checks:

  • Changelog entry added
  • Tests have been added (if applicable)
  • Branch prefixed with feature/ for new features (if applicable)
  • License headers added on new files (if applicable)

Review:

  • Milestone set
  • Review comments resolved

GitHub issues (if applicable):

@lnewson lnewson force-pushed the TINY-6475 branch 2 times, most recently from 61121d1 to 9b0c417 Compare October 1, 2020 02:26
Copy link
Contributor

@metricjs metricjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked into a couple things that felt odd, but they seem to all be existing implementation quirks. Otherwise LGTM with the recent changes.

@lnewson lnewson merged commit a693f6b into master Oct 1, 2020
@lnewson lnewson deleted the TINY-6475 branch October 1, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants