Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support default tinet volume #23

Merged
merged 2 commits into from
Feb 3, 2020
Merged

support default tinet volume #23

merged 2 commits into from
Feb 3, 2020

Conversation

ak1ra24
Copy link
Collaborator

@ak1ra24 ak1ra24 commented Feb 3, 2020

#20

@ak1ra24 ak1ra24 requested a review from slankdev February 3, 2020 00:30
@slankdev
Copy link
Contributor

slankdev commented Feb 3, 2020

https://github.com/slankdev/tinet/blob/master/bin/tn#L225-L226

We should provide nodes.volume_base interface to specify mount-point.
Sorry, my issue had not include enough infos to provide tinet-volume.

Copy link
Contributor

@slankdev slankdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, send patch, please edit more.

internal/pkg/shell/shell.go Outdated Show resolved Hide resolved
internal/pkg/shell/shell_test.go Show resolved Hide resolved
internal/pkg/shell/shell_test.go Show resolved Hide resolved
internal/pkg/shell/shell_test.go Show resolved Hide resolved
@ak1ra24
Copy link
Collaborator Author

ak1ra24 commented Feb 3, 2020

@slankdev

if len(node.Mounts) != 0 {

name: "create node with mounts",

#2

You can specify the volume.

@slankdev
Copy link
Contributor

slankdev commented Feb 3, 2020

@slankdev

if len(node.Mounts) != 0 {

name: "create node with mounts",

#2

You can specify the volume.

Mount option and tinet-volume are different feature , as a tinet-feature . I know both are using docker-volume.

Each feature should be provided via another interface.

internal/pkg/shell/shell_test.go Show resolved Hide resolved
@slankdev slankdev merged commit 631d89e into tinynetwork:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants