Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix down behavior #7

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Conversation

slankdev
Copy link
Contributor

related: #5

@slankdev slankdev requested a review from ak1ra24 January 31, 2020 05:51
@slankdev
Copy link
Contributor Author

I'll check that later.

@slankdev
Copy link
Contributor Author

slankdev commented Jan 31, 2020

@ak1ra24
About following link,
I see. I understand your input.

But why I suggest to use docker rm -f, not docker stop is the behavior of docker stop is depending to each docker images. (some container images can't stop faster, some container image take a bit second for stoping).

createNodeCmd = fmt.Sprintf("docker run -td --hostname %s --net %s --name %s --rm --privileged ", node.Name, node.NetBase, node.Name)

@ak1ra24
Copy link
Collaborator

ak1ra24 commented Jan 31, 2020

Thank you for your explanation.
I understand, so I agree with the pr.

Copy link
Collaborator

@ak1ra24 ak1ra24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slankdev slankdev merged commit 929f293 into tinynetwork:master Jan 31, 2020
@slankdev slankdev deleted the slankdev-fix-down branch January 31, 2020 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants