Breaking change to API, but with ear-clipping triangulation. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rary to facilitate the change.
|
Cool! I will review it as soon as possible! |
|
I have merged the PR and pushed into
You can use |
|
If you're willing to move to vector struct types, may I suggest you add a colour type too? It would make the materials a bit more readable for some people. I understand that this means there is a greater difference between the c and c++ versions than before.
fabs();
Sent from TypeApp
…On 12 Nov 2017 7:50 am, at 7:50 am, Syoyo Fujita ***@***.***> wrote:
I have merged the PR and pushed into `devel` branch.
`devel` branch will become version 2.0.0 after some code cleanups and
API re-design considering this issue
#141
You can use `devel` for a while for your own project.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#151 (comment)
|
|
Absolutely yes! > color type PR is always welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I have tested this with the concave polygon mesh I had, and it now seems to triangulate fine. I hope you find this example useful, but I don't know if you will want to pull it as it changes the API due to wanting to work with vectors to do the triangle checks. Sorry I couldn't easily do it without adding a tiny vertex type and changing the types.