tinyproxy.conf.5: document config strings that require double quotes #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
String config values matched by the STR regex must be enclosed in double quotes Edit descriptions for brevity conf.c: move boolean arguments comment before BOOL group addresses tinyproxy#491
ivanwick
commented
May 9, 2023
src/conf.c
Outdated
| @@ -199,8 +199,8 @@ struct { | |||
| STDCONF (defaulterrorfile, STR, handle_defaulterrorfile), | |||
| STDCONF (statfile, STR, handle_statfile), | |||
| STDCONF (stathost, STR, handle_stathost), | |||
| STDCONF (xtinyproxy, BOOL, handle_xtinyproxy), | |||
| /* boolean arguments */ | |||
There was a problem hiding this comment.
I saw the comment out of place when reviewing these regexes for the documentation about quoting. But this change can be reverted if we want to keep the PR strictly in the docs directory.
There was a problem hiding this comment.
yes, please move this to separate PR; it's unrelated to what this PR does.
There was a problem hiding this comment.
Reverted conf.c change in a806636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String config values matched by the STR regex must be enclosed in double quotes
Edit descriptions for brevity
conf.c: move boolean arguments comment before BOOL group
addresses #491