-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong ignore path and create a lot if features #168
Conversation
Looks great! I like the the concept of stages; nice idea. Couple of comments:
Thanks a lot for looking into this. |
I'll look into this, right now I can't reproduce the issue locally.
I've added a comment here oh GH, I'll add a comment in
The reason is like this: since the merger of two libs ( |
Didn't you remove
Cool! |
Here is a new version.
I hope, we'll see why it failed earlier with |
Guess we also need to update the CI pipelines; specifically the |
It seems that we need to replace actions-rs clippy implementation with another, better maintained one like here . |
Can you please take a look? |
Thanks for your patience. There was a typo in the pipeline, which I fixed real quick. Now it fails because the examples folder is missing a |
Co-authored-by: Matthias Endler <matthias@endler.dev>
It's failing on nightly. We'll probably have to upgrade the |
@ASMfreaK I just tried building this from git and then using it on a sample json file unsuccessfully: #151 (comment) @mre was considering going ahead and merging this and fixing the tests later, so I did a quick manual test of the branch. |
This PR fixes the issue of wrong import path for the engine. The fix is simple : we put everything needed for the wasm script to run in a single library, hosted on crates.io. (This includes former
engine
andshared
crates).I've also added a few features for overall more flexible usage:
examples
folder.