tests on linux + big file support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enough entropy has been read
…oblems with large files. the "should calculate sha1 correctly for a big file" test in validation_spec.rb will pass with this change and will fails without it
|
This is more thorough than mine (#3), so I'm closing mine in favor of this one. Incidentally, the place where FileUtils is used is in https://github.com/edsu/bagit-ruby/blob/f67dabaa95040d7daee3c20cc36f3ea74388f802/lib/bagit/bag.rb#L24 |
flazz
added a commit
that referenced
this pull request
Oct 13, 2011
tests on linux + big file support
|
You're welcome :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some changes to get tests passing on Ubuntu. More importantly there are changes to get checksums generated properly for large files. I noticed a client (gnip.com) sending loc.gov bags created with your software, with invalid SHA1 manifests.